2016-05-31 19:45:31 +00:00
|
|
|
From 5a0d703884a73f93a68753c6ed64bdf08797c82a Mon Sep 17 00:00:00 2001
|
2015-12-10 16:03:51 +00:00
|
|
|
From: Hector Marco-Gisbert <hecmargi@upv.es>
|
|
|
|
Date: Fri, 13 Nov 2015 16:21:09 +0100
|
2016-06-10 18:22:46 +00:00
|
|
|
Subject: [PATCH 72/83] Fix security issue when reading username and password
|
2015-12-10 16:03:51 +00:00
|
|
|
|
|
|
|
This patch fixes two integer underflows at:
|
|
|
|
* grub-core/lib/crypto.c
|
|
|
|
* grub-core/normal/auth.c
|
|
|
|
|
|
|
|
Resolves: CVE-2015-8370
|
|
|
|
|
|
|
|
Signed-off-by: Hector Marco-Gisbert <hecmargi@upv.es>
|
|
|
|
Signed-off-by: Ismael Ripoll-Ripoll <iripoll@disca.upv.es>
|
|
|
|
---
|
|
|
|
grub-core/lib/crypto.c | 2 +-
|
|
|
|
grub-core/normal/auth.c | 2 +-
|
|
|
|
2 files changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
|
|
|
|
diff --git a/grub-core/lib/crypto.c b/grub-core/lib/crypto.c
|
2016-03-04 18:32:29 +00:00
|
|
|
index 683a8aa..c5ab9eb 100644
|
2015-12-10 16:03:51 +00:00
|
|
|
--- a/grub-core/lib/crypto.c
|
|
|
|
+++ b/grub-core/lib/crypto.c
|
|
|
|
@@ -468,7 +468,7 @@ grub_password_get (char buf[], unsigned buf_size)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
- if (key == '\b')
|
|
|
|
+ if (key == '\b' && cur_len)
|
|
|
|
{
|
2016-03-04 18:32:29 +00:00
|
|
|
if (cur_len)
|
|
|
|
cur_len--;
|
2015-12-10 16:03:51 +00:00
|
|
|
diff --git a/grub-core/normal/auth.c b/grub-core/normal/auth.c
|
2016-03-04 18:32:29 +00:00
|
|
|
index 7338f82..6d6dc7d 100644
|
2015-12-10 16:03:51 +00:00
|
|
|
--- a/grub-core/normal/auth.c
|
|
|
|
+++ b/grub-core/normal/auth.c
|
|
|
|
@@ -172,7 +172,7 @@ grub_username_get (char buf[], unsigned buf_size)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
- if (key == '\b')
|
|
|
|
+ if (key == '\b' && cur_len)
|
|
|
|
{
|
2016-03-04 18:32:29 +00:00
|
|
|
if (cur_len)
|
|
|
|
{
|
2015-12-10 16:03:51 +00:00
|
|
|
--
|
2016-05-31 19:45:31 +00:00
|
|
|
2.7.4
|
2015-12-10 16:03:51 +00:00
|
|
|
|