Update wit feedback from Petr Kovar's review

As per

https://gitlab.cee.redhat.com/ccs-internal-documentation/fedora-quick-docs/merge_requests/26#note_245444
This commit is contained in:
Melanie Corr 2017-12-19 09:41:34 +00:00
parent 33bc86cb6f
commit 34e685245c
3 changed files with 8 additions and 10 deletions

View file

@ -11,13 +11,11 @@ Guide]. It is archived.
[NOTE]
This document is not an official Fedora packaging guideline. This page
is open for editing by the general Fedora packaging community, while the
actual packaging guidelines are managed by the
https://fedoraproject.org/wiki/Packaging_Committee?rd=Packaging:Committee[Packaging Committee].
is open for editing by the general Fedora packaging community. For a general-purpose RPM building guide for packagers on Fedora, CentOS and Red Hat Enterprise Linux, see the https://rpm-packaging-guide.github.io/[RPM Packaging Guide].
For more information about packaging guidelines, see the following guides:
* https://rpm-packaging-guide.github.io/#introduction[Packaging Guidelines]
* https://fedoraproject.org/wiki/Packaging:Guidelines[Packaging Guidelines]
* http://fedoraproject.org/wiki/Packaging:LicensingGuidelines[Licensing Guidelines]
* http://fedoraproject.org/wiki/Packaging:Naming[ Package Naming Guidelines]
* http://fedoraproject.org/wiki/Packaging:DistTag[ Dist Tag Guidelines]
@ -55,7 +53,7 @@ For a full list of guidelines related to macros, see http://fedoraproject.org/wi
.mock
A system for building RPMs within their own separate small Fedora installation. This avoids the need to install a full set of build dependencies on your operating system installation, and allows you to build packages for different Fedora releases.
A system for building RPMs locally within your own Fedora installation. This avoids the need to install a full set of build dependencies on your operating system installation, and allows you to build packages for different Fedora releases.
.koji
The main Fedora build system: https://koji.fedoraproject.org[1].

View file

@ -44,7 +44,7 @@ If there is more than one source, name them `Source1`, `Source2`.
If you add whole new files in addition to the pristine sources, list them as sources after the pristine sources. A copy of each of these sources is included in any source RPM (SRPM) you create, unless you specifically direct otherwise. For more information on special cases, for example, revision control, see https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL[Source URL].
.Patch0
Enter the name of the first patch to apply to the source code. If you must patch the files after you extract them, edit the files and save their differences as a "patch" file in your `~/rpmbuild/SOURCES` directory. Patches must make only one logical change each, so it's quite possible to have multiple patch files.
Enter the name of the first patch to apply to the source code. If you must patch the files after you extract them, edit the files and save their differences as a `.patch` file in your `~/rpmbuild/SOURCES` directory. Patches must make only one logical change each, so it's quite possible to have multiple patch files.
.BuildArch
If you package files that are architecture-independent, for example shell scripts, data files, then add `BuildArch: noarch`. The architecture for the binary RPM is then `noarch`.

View file

@ -80,7 +80,7 @@ files there.
. Save your edits and to run a local build, enter the following command:
+
-----
$ fedpkg --release f`` local
$ fedpkg --release f27 local
-----
This updates the two RPMs.
@ -98,7 +98,7 @@ BuildArch: noarch
. Delete the existing `.rpm` files in this directory and run another local build:
+
-----
$ fedpkg --release f`` local
$ fedpkg --release f27 local
-----
.Result
@ -113,7 +113,7 @@ After you complete the procedure, ensure that you have the following two files:
Validate your RPM package with RPM lint, using the following command:
----
fedpkg --release f`` lint
fedpkg --release f27 lint
----
At this stage, there are four or more errors because of the lack of `%prep`, `%build` sections, and `URL` tag.